fix: show error messages when API exceptions occur in s12-s20#362
Merged
Conversation
Panda-eyes123
commented
Jun 14, 2026
Panda-eyes123
commented
Contributor
- Fixed silent error swallowing in s12-s20's agent loops.
- The bug: when API throws an exception, the except block stores it as a plain dict in messages, but the final display loop uses getattr(block, "type", None) which returns None for dicts (not objects), so the error message is never printed.The current state is "it runs but errors are invisible", which is the worst possible state.
- s14 already had the fix, s20 used the existing block_type() helper.
- Following the style of s14, fixed by adding '' elif isinstance(block, dict) and block.get("type") == "text": print(block.get("text", "")) '' to s12, s13, s15-s19, and using block_type() in s20.
|
@Panda-eyes123 is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks for this, it is a clean catch. Confirmed in s12: the error is stored as a dict block, but the display loop only handled SDK objects via getattr(block, "type", None), so it got swallowed; your fix matches s14 and brings the other chapters in line. Minimal, reuses block_type in s20, and the loop is not in any README so no doc sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.